this second condition identifies areas of the code as high-risk and off-limits entirely:
"Non-critical" means that it is extremely unlikely for the PR to cause a soundness regression.
ℹ️ Examples:
Changes to internal tooling like tidy, x setup, and linkchecker are probably ok.
Changes that have a strong soundness impact, like the trait system, MIR building, or the query system are probably not ok.
identifying sections of a codebase as high-risk and subject to stronger review requirements is imho incredibly significant. this is the kind of precedent i would like to see in actual legislation, and indeed the EU "AI Act" was specifically lauded for establishing an analogous hierarchy of risk that subjected certain applications to greater scrutiny.
(unfortunately, the same act also completely discarded scrutiny and safety requirements if the "AI" was used for border control or counter"terrorism". so it creates a regulatory structure as a sham and refuses to regulate the most fascist shit, which is classic EU behavior. but they created the sham because it would have been actually good to have)