@grahamperrin
I think that advice predates the unified buffer cache.
I have a machine with 64 GiB of RAM and 64 GB of swap, mostly because the disks are big and it’s sometimes useful to have a partition you can nuke (I installed FreeBSD on a BIOS-only machine and then replaced the motherboard with a UEFI-only one, so it was very useful to have space to pop a UEFI partition). But I don’t think I’ve seen it put even 1 GiB in swap.
Quite a few processes have some pages that are used on startup and not touched, and if you leave them for long enough these will eventually be swapped out and the RAM used for hotter disk pages, but these days a lot of RAM is typically filled with disk cache and will be preferentially evicted in case of memory pressure.
I’ve seen large swap cause some real problems with processes with run-away allocation. The process grows to fill RAM and swap, then segfaults and dumps core. Dumping core requires paging in every page that was swapped out and writing it to disk. That can take a really long time, hurt system performance while it’s happening and, if you’re really unlucky, fill up the disk (bonus points if the program was running as root).