Discussion
Loading...

Post

  • About
  • Code of conduct
  • Privacy
  • Users
  • Instances
  • About Bonfire
Esparta :ruby:
@esparta@ruby.social  ·  activity timestamp 7 days ago

it's not uncommon to review patches and found adding `ActiveSupport::Concern` to a module, I guess are copy-paste?

> if we are not using anything related to `ActiveSupport::Concern` such as `included` or `class_method` blocks, then there's no need to be added since this would be a normal #ruby module

an screenshot of a pee-review of a code where I'm asking to remove a line with the following comment:

> if we are not using anything related to ActiveSupport::Concern such as `included` or `class_method` blocks, then there's no need to be added since this would be a normal ruby module
an screenshot of a pee-review of a code where I'm asking to remove a line with the following comment: > if we are not using anything related to ActiveSupport::Concern such as `included` or `class_method` blocks, then there's no need to be added since this would be a normal ruby module
an screenshot of a pee-review of a code where I'm asking to remove a line with the following comment: > if we are not using anything related to ActiveSupport::Concern such as `included` or `class_method` blocks, then there's no need to be added since this would be a normal ruby module
  • Copy link
  • Flag this post
  • Block
Esparta :ruby:
@esparta@ruby.social replied  ·  activity timestamp 2 days ago

changing strategy about extra `ActiveSupport::Concern` inclusions, hope this helps 😊

> if we are not using features as `included`, `class_methods` blocks or autoloading modules, then let's remove it and keep it nice, lean, organic, all-natural, GMO-free #ruby module

An screenshot of a patch request where I'm replying this:

> if we are not using features as included, class_method blocks or autoloading modules, then let's remove it and keep it nice, lean, organic, all-natural, GMO-free #ruby module
An screenshot of a patch request where I'm replying this: > if we are not using features as included, class_method blocks or autoloading modules, then let's remove it and keep it nice, lean, organic, all-natural, GMO-free #ruby module
An screenshot of a patch request where I'm replying this: > if we are not using features as included, class_method blocks or autoloading modules, then let's remove it and keep it nice, lean, organic, all-natural, GMO-free #ruby module
  • Copy link
  • Flag this comment
  • Block
PointlessOne :loading:
@pointlessone@status.pointless.one replied  ·  activity timestamp 2 days ago

@esparta GMO shaming is uncalled though.

  • Copy link
  • Flag this comment
  • Block
Esparta :ruby:
@esparta@ruby.social replied  ·  activity timestamp 2 days ago

@pointlessone yeah... didn't though about that, previously I had fat-free but it's also shammy.
The GMO is not against GMO itself, but companies who uses GMO as a greenwashing: they past 1 single certificate and make it seems like the whole company is conscious

  • Copy link
  • Flag this comment
  • Block
PointlessOne :loading:
@pointlessone@status.pointless.one replied  ·  activity timestamp 2 days ago

@esparta Yeah. I suggest “all-natural” or "free range”. Or both in a case like this.

  • Copy link
  • Flag this comment
  • Block
Abdullah Esmail
@aesmail@ruby.social replied  ·  activity timestamp 7 days ago

@esparta might be worth mentioning that `ActiveSupport::Concern` offers easier (automatic) handling of module dependencies (including a module inside another module).

  • Copy link
  • Flag this comment
  • Block
Esparta :ruby:
@esparta@ruby.social replied  ·  activity timestamp 6 days ago

@aesmail I agree, but in most of the cases there were nothing on, just a #ruby module with methods. So I don't think is worthy extending `ActiveSupport::Concern` just because.

  • Copy link
  • Flag this comment
  • Block
Log in

bonfire.cafe

A space for Bonfire maintainers and contributors to communicate

bonfire.cafe: About · Code of conduct · Privacy · Users · Instances
Bonfire social · 1.0.0 no JS en
Automatic federation enabled
  • Explore
  • About
  • Members
  • Code of Conduct
Home
Login