Ooof.
So, #iocaine has a dependency on tikv-jemalloc, and uses it by default. Unfortunately, that crate doesn't compile on FreeBSD (and is unnecessary there in the first place).
So I'm trying to figure out how to make it optional, but still default on Linux.
I can trivially make it fully optional, if I also make it non-default. But making it default on linux only is proving to be a bit tricky.
..partly because #cfg(target_os = "linux") appers to be true when compiling with --target x86_64-unknown-freebsd.
Oh! Okay. I understand why target_os is linux in this case!
It's compiling build.rs, and that is always native, so the target OS there is appropriate when cross-compiling.
I need to check CARGO_CFG_TARGET_OS instead.
Hrm. Turns out, it does compile, if compiling natively. It's just not very useful. I guess --no-default-features may be acceptable... but I'd like to do it better.
It looks like the least wrong way about this would be to leave jemalloc on as a default feature, but teach iocaine to ignore that on FreeBSD, like it is ignored when compiling against musl, too.
That way the tikv-jemallocator crate remains a hard dependency, the feature remains enabled, but FreeBSD will use the native allocator (which, iirc is also jemalloc, or jemalloc-derived in the first place).
I think this'll do.
A space for Bonfire maintainers and contributors to communicate
