Post by @linc@phpc.social

Occasionally, it's a drawback to be fluent in the old ways. Wrote this too-clever #PHP code and died a little inside:

`if (!in_array(strpos($dst, '='), [0, false, strlen($dst) - 1]))`

Then a little voice inside me said "didn't PHP 8 add some string functions..."

It did! Thus:

`if (str_contains($dst, '=') && !str_starts_with($dst, '=') && !str_ends_with($dst, '='))`

Yay for code that doesn't require a PhD in wtf were you thinking 😂

2 Replies

0 Boosts

@linc It would pass through 'a=b=' anyway.

I'd use sth like `strpos() && trim() === $var`. Things like these deserve explanatory variable/method though.

@linc Staring at it made me think of a potential optimization, but that probably should be handled by the engine so I opened a ticket :)

Optimization idea: optimize str_{starts|ends}_wtih() with a 1 byte needle string to $haystack[{0|-1}] === $needle · Issue #23476 · php/php-src