Discussion
Loading...

Post

  • About
  • Code of conduct
  • Privacy
  • Users
  • Instances
  • About Bonfire
Martin Owens :inkscape:
@doctormo@floss.social  ·  activity timestamp last week

Hey, do you know CMake? Can you spare a couple of minutes to do a code review? The Inkscape project sometimes struggles to find experts in some tools to do reviews and you could be a great help just looking over this include construct for unit tests (we're trying to do more unit testing)

https://gitlab.com/inkscape/inkscape/-/merge_requests/7447/diffs#aef5f525afa24090506b1f6b4def8a3c2fb76126_174_153

Q: Is this ok to include a CMakeLists when putting together a list of cpp files for the unit test builder?

#cpp #cmake #programming #foss

  • Copy link
  • Flag this post
  • Block
d@nny disc@ mc²
@hipsterelectron@circumstances.run replied  ·  activity timestamp last week

@doctormo another way to do this is to refer not to the set of source files but to the target those files are built under and then to extract the sources from that. it's not clear if you're trying to do something very special since i know testing can involve some metaprogramming

  • Copy link
  • Flag this comment
  • Block
Martin Owens :inkscape:
@doctormo@floss.social replied  ·  activity timestamp last week

@hipsterelectron

I don't believe the parts of inkscape are split up into their own targets. The CMakeList of each sub directory adds everything to a single build target for the inkscape binary.

This is the first baby steps of splitting things out. Should they be their own target? (and what would that look like?)

  • Copy link
  • Flag this comment
  • Block
Log in

bonfire.cafe

A space for Bonfire maintainers and contributors to communicate

bonfire.cafe: About · Code of conduct · Privacy · Users · Instances
Bonfire social · 1.0.0-rc.3.13 no JS en
Automatic federation enabled
  • Explore
  • About
  • Members
  • Code of Conduct
Home
Login