Discussion · bonfire.cafe

@amaarets@community.nodebb.org · last week

Is Safari intentionally excluded from the Service Worker installation?

I saw that there is an exception for the Safari browser that the Service Worker is not installed, is there a reason for this?

https://github.com/NodeBB/NodeBB/blob/b1e4248b56f4b9fe4b1cef778debd94333445c6e/public/src/app.js#L355

This makes it impossible to subscribe to push notifications in the Safari browser even when installing the page as a PWA application

I saw that there is an exception for the Safari browser that the Service Worker is not installed, is there a reason for this?

https://github.com/NodeBB/NodeBB/blob/b1e4248b56f4b9fe4b1cef778debd94333445c6e/public/src/app.js#L355

This makes it impossible to subscribe to push notifications in the Safari browser even when installing the page as a PWA application

GitHub

NodeBB/public/src/app.js at b1e4248b56f4b9fe4b1cef778debd94333445c6e · NodeBB/NodeBB

Node.js based forum software built for the modern web - NodeBB/NodeBB

nil!

@baris@community.nodebb.org · 2 hours ago

Is Safari intentionally excluded from the Service Worker installation?

I think all the functionality is in nodebb-plugin-web-push. The notification is shown here https://github.com/NodeBB/nodebb-plugin-web-push/blob/main/static/web-push.js#L16. You can check there if every chat message push comes with a different body or if they are identical.

GitHub

nodebb-plugin-web-push/static/web-push.js at main · NodeBB/nodebb-plugin-web-push

Push Notifications (via Push API) for NodeBB. Contribute to NodeBB/nodebb-plugin-web-push development by creating an account on GitHub.

julian

@julian@community.nodebb.org · 1 hour ago

Is Safari intentionally excluded from the Service Worker installation?

@שניאור-שמח my best guess is that the notification is received by web push and it does not correctly "rescind" the push notification when issuing a new one with an identical merge id

However if it works with Android then that suggests that it may be an apple specific issue with how they handle notification rescind. Maybe they require additional data the plugin doesn't send.

Hopefully they support notification rescind.

nil!

@baris@community.nodebb.org · 2 days ago

Is Safari intentionally excluded from the Service Worker installation?

These are push notifications so they are likely handled in the web-push plugin, I see a PR there https://github.com/NodeBB/nodebb-plugin-web-push/pull/64 that might fix this issue @julian

GitHub

i18n: add Hebrew translation for plugin terms by ClickAndGoScript · Pull Request #64 · NodeBB/nodebb-plugin-web-push

This PR adds Hebrew (he) translation support for the plugin.

שניאור שמח

@שניאור-שמח@community.nodebb.org · 2 days ago

Is Safari intentionally excluded from the Service Worker installation?

@baris That's right, that's what I have installed, but it only helped the notifications appear on the iPhone in the Safari browser, but it still didn't help with the notification merging problem.

So I ask you to try to sort this out.
thanks.

julian

@julian@community.nodebb.org · 2 days ago

Is Safari intentionally excluded from the Service Worker installation?

@שניאור-שמח are chats the only type of notification failing at merging?

@baris web push is a direct reflection of regular notifications so if they share merge id, the old push notif is removed and replaced