Discussion
Loading...
@tvbeek I’m curious if this works for projects packaged with `git archive`.
@ramsey Interesting question, I personal never have used a git archive.
If I read it correctly it creates an archive from your repository, but maybe I'm wrong.
The current finders doesn't work with an archive ( see: https://gitlab.com/tjvb/githash#different-hashfinders )
And I'm thinking, how do you run a project that is inside an archive 🤔 but if possible it can be interesting to add support for it.
@tvbeek When you download zip files from GitHub (which is what Composer defaults to unless using --prefer-source), those zip files are created using `git archive`. That command is what uses the `.gitattributes` file to ignore files from the distribution.
@ramsey I did a fast check and in the zip file I didn't see any reference about a version.
Maybe I need to document in a clear way that the package target is to get the version from the project/application and not from a dependency.
@tvbeek No worries. I think it’s clear that this isn’t intended for use with dependencies. I was mainly curious for those who distribute full applications via archives—I guess they should have some kind of build step that sets the version before bundling it; I’ve been looking for a way to do this without that build step.
1 more replies (not shown)